[LLVM][Support] Minor code cleanup in InterleavedRange#175237
Merged
[LLVM][Support] Minor code cleanup in InterleavedRange#175237
InterleavedRange#175237Conversation
Remove redundant empty checks for prefix/suffix strings and flush() for raw_string_ostream.
Member
|
@llvm/pr-subscribers-llvm-support Author: Rahul Joshi (jurahul) ChangesRemove redundant empty checks for prefix/suffix strings and flush() for raw_string_ostream. Full diff: https://github.com/llvm/llvm-project/pull/175237.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/InterleavedRange.h b/llvm/include/llvm/Support/InterleavedRange.h
index ce7cac98bcdd4..2c7b87036f4d1 100644
--- a/llvm/include/llvm/Support/InterleavedRange.h
+++ b/llvm/include/llvm/Support/InterleavedRange.h
@@ -44,11 +44,9 @@ template <typename Range> class InterleavedRange {
template <typename OStream>
friend OStream &operator<<(OStream &OS, const InterleavedRange &Interleaved) {
- if (!Interleaved.Prefix.empty())
- OS << Interleaved.Prefix;
+ OS << Interleaved.Prefix;
llvm::interleave(Interleaved.TheRange, OS, Interleaved.Separator);
- if (!Interleaved.Suffix.empty())
- OS << Interleaved.Suffix;
+ OS << Interleaved.Suffix;
return OS;
}
@@ -56,7 +54,6 @@ template <typename Range> class InterleavedRange {
std::string Result;
raw_string_ostream Stream(Result);
Stream << *this;
- Stream.flush();
return Result;
}
|
kuhar
approved these changes
Jan 10, 2026
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Jan 18, 2026
Remove redundant empty checks for prefix/suffix strings and flush() for raw_string_ostream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant empty checks for prefix/suffix strings and flush() for raw_string_ostream.